Changeset 1356

Show
Ignore:
Timestamp:
01/29/08 00:08:53 (7 months ago)
Author:
Neal
Message:

Added a new parameter to the logout URL to prevent a CSRF annoyance.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • trunk/upload/include/functions.php

    r1098 r1356  
    296296 
    297297                        $links[] = '<li id="navprofile"><a href="profile.php?id='.$pun_user['id'].'">'.$lang_common['Profile'].'</a>'; 
    298                         $links[] = '<li id="navlogout"><a href="login.php?action=out&amp;id='.$pun_user['id'].'">'.$lang_common['Logout'].'</a>'; 
     298                        $links[] = '<li id="navlogout"><a href="login.php?action=out&amp;id='.$pun_user['id'].'&amp;csrf_token='.sha1($pun_user['id'].sha1(get_remote_address())).'">'.$lang_common['Logout'].'</a>'; 
    299299                } 
    300300                else 
     
    303303                        $links[] = '<li id="navprofile"><a href="profile.php?id='.$pun_user['id'].'">'.$lang_common['Profile'].'</a>'; 
    304304                        $links[] = '<li id="navadmin"><a href="admin_index.php">'.$lang_common['Admin'].'</a>'; 
    305                         $links[] = '<li id="navlogout"><a href="login.php?action=out&amp;id='.$pun_user['id'].'">'.$lang_common['Logout'].'</a>'; 
     305                        $links[] = '<li id="navlogout"><a href="login.php?action=out&amp;id='.$pun_user['id'].'&amp;csrf_token='.sha1($pun_user['id'].sha1(get_remote_address())).'">'.$lang_common['Logout'].'</a>'; 
    306306                } 
    307307        } 
  • trunk/upload/login.php

    r431 r1356  
    8585else if ($action == 'out') 
    8686{ 
    87         if ($pun_user['is_guest'] || !isset($_GET['id']) || $_GET['id'] != $pun_user['id']
     87        if ($pun_user['is_guest'] || !isset($_GET['id']) || $_GET['id'] != $pun_user['id'] || !isset($_GET['csrf_token']) || $_GET['csrf_token'] != sha1($pun_user['id'].sha1(get_remote_address()))
    8888        { 
    8989                header('Location: index.php');