Changeset 773

Timestamp:

01/15/07 01:07:18 (2 years ago)

Author:

Neal

Message:

Fix for users appearing multiple times in the online list. Also fixes "Mark topics as read" failing after timeout.

Files:

• trunk/extras/12_to_1214_update.php (modified) (1 diff)
• trunk/upload/include/functions.php (modified) (4 diffs)
• trunk/upload/install.php (modified) (1 diff)

trunk/extras/12_to_1214_update.php

@@ -124 +124 @@
-        }
-
+        // We need to add a unique index to avoid users having multiple rows in the online table
+        if ($db_type == 'mysql' || $db_type == 'mysqli')
+        {
+                $result = $db->query('SHOW INDEX FROM '.$db->prefix.'online') or error('Unable to check DB structure.', __FILE__, __LINE__, $db->error());
+
+                if ($db->num_rows($result) == 1)
+                        $db->query('ALTER TABLE '.$db->prefix.'online ADD UNIQUE INDEX '.$db->prefix.'online_user_id_ident_idx(user_id,ident)') or error('Unable to alter DB structure.', __FILE__, __LINE__, $db->error());
+        }
-
-        // This feels like a good time to synchronize the forums

trunk/upload/include/functions.php

@@ -28 +28 @@
-function check_cookie(&$pun_user)
-{
-
+db_type, $
-
-        $now = time();
@@ -76 +76 @@
-                        // Update the online list
-                        if (!$pun_user['logged'])
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
-                        else
-                        {
@@ -103 +118 @@
-function set_default_user()
-{
-
+db_type, $
-
-        $remote_addr = get_remote_address();
@@ -116 +131 @@
-        // Update online list
-        if (!$pun_user['logged'])
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
-        else
-                $db->query('UPDATE '.$db->prefix.'online SET logged='.time().' WHERE ident=\''.$db->escape($remote_addr).'\'') or error('Unable to update online list', __FILE__, __LINE__, $db->error());

trunk/upload/install.php

@@ -1235 +1235 @@
-                case 'mysqli':
-                        // We use MySQL's ALTER TABLE ... ADD INDEX syntax instead of CREATE INDEX to avoid problems with users lacking the INDEX privilege
+                        $queries[] = 'ALTER TABLE '.$db_prefix.'online ADD UNIQUE INDEX '.$db_prefix.'online_user_id_ident_idx(user_id,ident)';
-                        $queries[] = 'ALTER TABLE '.$db_prefix.'online ADD INDEX '.$db_prefix.'online_user_id_idx(user_id)';
-                        $queries[] = 'ALTER TABLE '.$db_prefix.'posts ADD INDEX '.$db_prefix.'posts_topic_id_idx(topic_id)';