Ticket #84 (assigned enhancement)

Opened 5 months ago

Last modified 4 months ago

Add IPv6 support

Reported by: Neal Assigned to: Neal (accepted)
Priority: normal Milestone: 1.3
Component: general Version: 1.2.*
Severity: normal Keywords:
Cc:

Description

It was recently pointed out that PunBB does not support IPv6 properly:

  • We use VARCHAR(15) to store IPs, which is too small for IPv6. It needs VARCHAR(39)
  • We check the format of IP addresses several places and we don't accept IPv6 style addresses anywhere.

So, changes should be made such that we are IPv6 compatible. :)

Attachments

ipv6.patch (6.6 kB) - added by Neal on 04/07/08 00:29:56.
A patch to add basic IPv6 support to PunBB. Still missing: SQLite support, bans

Change History

04/07/08 00:27:35 changed by Neal

  • status changed from new to assigned.

The one sticking point here is changing the size of the columns.

MySQL is simple, it just requires ALTER TABLE CHANGE. PostgreSQL is slightly harder, we need to create a new column with the right type, move the data over, remove the old column, and give the new column the proper name. SQLite is the most difficult, since it does not allow for the removal or renaming of columns. We'll have to find a way around it, both for here and for elsewhere.

04/07/08 00:29:56 changed by Neal

  • attachment ipv6.patch added.

A patch to add basic IPv6 support to PunBB. Still missing: SQLite support, bans

04/09/08 00:48:34 changed by Neal

http://punbb.org/forums/viewtopic.php?pid=113038#p113038 

SQLite should actually be the easiest, because it does not enforce type
checking. The column types are basically for the benefit of anyone
reading the schema -- you can put any type of data in any column.
That includes storing strings of any length. See this page, under
"Manifest typing" (and I suppose the "Variable-length records" bit
is also relevant).

So, as far as I can tell, there shouldn't actually be any updating
needed for SQLite.